The trigger name seems opposite to how it operates

David · November 5, 2024, 9:23pm

The trigger is called User left home, but it triggers when the user returns home.

Counterintuitive

The trigger User back home also does the opposite of what you might expect.

Thank you!

pierre-gilles · November 7, 2024, 4:56pm

Indeed you’re right !

I think the title is wrong:

Screenshot 2024-11-07 at 17.55.24

Thanks for reporting, I’ll fix this

pierre-gilles · November 8, 2024, 12:51pm

Fixed in this PR :

github.com/GladysAssistant/Gladys

Fix translation in user back/left home trigger

GladysAssistant:master ← GladysAssistant:fix-user-back-home-translations

opened 12:32PM - 08 Nov 24 UTC

Pierre-Gilles

+4 -4

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [x] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. ### Description of change Translations were reversed

It’ll go live in the next release of Gladys !

Thanks again for reporting